-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow snapshots to be defined in YAML. #10749
Open
peterallenwebb
wants to merge
9
commits into
main
Choose a base branch
from
paw/define-snapshots-in-yaml
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10749 +/- ##
==========================================
+ Coverage 88.95% 89.01% +0.05%
==========================================
Files 181 181
Lines 22959 22995 +36
==========================================
+ Hits 20424 20469 +45
+ Misses 2535 2526 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* add behavior deprecation snowplow callback * update tests for new callback * update test input with the new required field
* [tidy first] Replace `TestSelector` with `ResourceTypeSelector` * Changelog entry * Fully preserve current behavior * Revert "Fully preserve current behavior" This reverts commit ceecfec.
…environment variables for `dbt test` (#10706) * Adding logic to TestSelector to remove unit tests if they are in excluded_resource_types * Adding change log * Respect `--resource-type` and `--exclude-resource-type` CLI flags and associated environment variables * Test CLI flag for excluding unit tests for the `dbt test` command * Satisy isort pre-commit hook * Fix mypy for positional argument "resource_types" in call to "TestSelector" * Replace `TestSelector` with `ResourceTypeSelector` * Add co-author * Update changelog description * Add functional tests for new feature * Compare the actual results, not just the count * Remove test case covered elsewhere * Test for `DBT_EXCLUDE_RESOURCE_TYPES` environment variable for `dbt test` * Update per pre-commit hook * Restore to original form (until we refactor extraneous `ResourceTypeSelector` references later) --------- Co-authored-by: Matthew Cooper <[email protected]>
…and `dbt build` (#10739) * Remove duplicated constructor for `ResourceTypeSelector` * Add type annotation for `ResourceTypeSelector` * Standardize on constructor for `ResourceTypeSelector` where `include_empty_nodes=True` * Changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10246
Problem
Users had to awkwardly create jinja snapshot blocks in SQL files, even for very simple snapshots.
Solution
Delight users by allowing snapshots to be defined intuitively, with just a few lines of YAML.
Checklist