Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add model_incremental_strategy to track_model_run #10758

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 23, 2024

Resolves #10761 https://github.com/dbt-labs/iglu.getdbt.com/issues/28

Problem

In order to track adoption of the new microbatch strategy, we'll need to track which incremental_strategy configs users are setting.

Solution

Obtain the optional incremental strategy config and plumb it through the tracking event.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Sep 23, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.97%. Comparing base (db69473) to head (3c0760e).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10758   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files         181      181           
  Lines       22956    22958    +2     
=======================================
+ Hits        20424    20426    +2     
  Misses       2532     2532           
Flag Coverage Δ
integration 86.14% <100.00%> (+<0.01%) ⬆️
unit 62.44% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.44% <33.33%> (-0.01%) ⬇️
Integration Tests 86.14% <100.00%> (+<0.01%) ⬆️

@MichelleArk MichelleArk marked this pull request as ready for review September 23, 2024 14:55
@MichelleArk MichelleArk requested a review from a team as a code owner September 23, 2024 14:55
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MichelleArk MichelleArk merged commit 9491743 into main Sep 30, 2024
67 of 68 checks passed
@MichelleArk MichelleArk deleted the track-incremental-strategy branch September 30, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track incremental_strategy as part of model_run tracking event
2 participants