Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre_hook/post_hook aliases to config (#1124) #1146

Merged
merged 3 commits into from
Nov 26, 2018

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Nov 21, 2018

Fixes #1124 by allowing users to use pre_hook and post_hook in keyword arguments to the config. If a user puts both pre-hook and pre_hook into a config's arguments, dbt will raise a compiler error:

Encountered an error:
Compilation Error in model data (models/data.sql)
  Invalid config, has conflicting keys "pre_hook" and "pre-hook"

dbt/context/parser.py Outdated Show resolved Hide resolved
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@beckjake beckjake merged commit b751ed6 into dev/grace-kelly Nov 26, 2018
@beckjake beckjake deleted the feature/hook-config-aliases branch November 26, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants