Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build on all dev branches, build on any branch named starting with "pr/" #1378

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Mar 26, 2019

This changes the azure pipelines CI process a bit. Instead of only running on changes to master, it will now run on any changes to:

  • master
  • any branch that starts with dev/
  • any branch that starts with pr/

The latter should help with contributor PR testing, though it's kind of hacky: Basically, do all the things you'd do to trigger circleci builds, except make sure you've named your branch starting with "pr/".

I don't think this is the most elegant solution possible, and we'll want to prune our branches, but it's something.

@beckjake beckjake changed the title build on all dev branches, build on any commit tagged "pr.xxx" build on all dev branches, build on any branch named starting with "pr/" Mar 26, 2019
Copy link
Member

@cmcarthur cmcarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@beckjake beckjake merged commit 0cd0792 into dev/wilt-chamberlain Apr 2, 2019
@beckjake beckjake deleted the ci/add-build-tag branch April 2, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants