Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/snowflake secure view 4 #1743

Conversation

Carolus-Holman
Copy link
Contributor

@Carolus-Holman Carolus-Holman commented Sep 11, 2019

Fixes #1730

Updated impl.py and adapters.sql to implement a switch to enable secure view syntax in the Snowflake View creation SQL.
{{ config(materialized='view',secure=true) }}

Will output the word SECURE into the View creation code sent to Snowflake.
The Default view is set to false for the secure feature.

@cla-bot
Copy link

cla-bot bot commented Sep 11, 2019

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @Carolus-Holman

@drewbanin
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Sep 11, 2019
@cla-bot
Copy link

cla-bot bot commented Sep 11, 2019

The cla-bot has been summoned, and re-checked this pull request!

@drewbanin
Copy link
Contributor

woohoo! Thanks for working through that CLA issue @Carolus-Holman! I think we're in good shape now :)

I'm going to kick off the test suite, then I think we'll be good to merge this pending any issues!

@drewbanin
Copy link
Contributor

GitHub is linking to the wrong Azure build -- the right one is here: https://dev.azure.com/fishtown-analytics/dbt/_build/results?buildId=654

These tests are all passing - going to merge this! Thanks for your contribution to dbt @Carolus-Holman :D

@drewbanin drewbanin merged commit 5dc776f into dbt-labs:dev/louisa-may-alcott Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Snowflake Secure Views
2 participants