Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make run-operation a ManifestTask #1792

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Sep 27, 2019

This fixes an issue introduced in #1750 where if you accessed the graph context member via run-operation or the RPC server it was None, but it was correct elsewhere. Pretty silly!

Make run-operation a ManifestTask and build a flat graph so it has the "graph" context member
Make sure the RPC server task calls build_flat_graph in __init__
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@beckjake beckjake merged commit c211d0e into dev/0.14.3 Sep 27, 2019
@beckjake beckjake deleted the fix/run-operation-flat-graph branch September 27, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants