Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Error Messaging for Invalid Source Arguments #1809

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Improve Error Messaging for Invalid Source Arguments #1809

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a5c0eb
SourceResolver call to use *args
Oct 5, 2019
a1d93f9
refactor to make more similar to RefResolver
Oct 5, 2019
b71e51e
Fix typo in error message
Oct 5, 2019
34cb9c7
Reduce line length for pep8
elikastelein Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions core/dbt/context/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,16 @@ def __call__(self, *args):


class SourceResolver(dbt.context.common.BaseResolver):
def __call__(self, source_name, table_name):
def __call__(self, *args):
# When you call source(), this is what happens at parse time
self.model.sources.append([source_name, table_name])
if len(args) == 2:
self.model.sources.append(list(args))

else:
dbt.exceptions.raise_compiler_error(
"source() takes exactly two arguments ({} given)"
.format(len(args)), self.model)

return self.Relation.create_from(self.config, self.model)


Expand Down