Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issues with some Mojave installs #1831

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Oct 14, 2019

Use an internal multiprocessing.context in dbt.flags for multiprocessing things

OSX will probably be a bit slower for RPC startup and SIGHUP handling now, as the manifest has to get pickled/unpickled for each API call. But at least it won't abort!

…ted?)

Use an internal multiprocessing.context in dbt.flags for multiprocessing things
 - On osx, force the use of "spawn" to handle https://bugs.python.org/issue33725
 - Bring _nt_setup back from the dead as _spawn_setup
@cla-bot cla-bot bot added the cla:yes label Oct 14, 2019
@beckjake beckjake changed the title Speculative fix for issues with some Mojave installs Fix for issues with some Mojave installs Oct 14, 2019
@beckjake beckjake changed the base branch from feature/improve-rpc-compile-performance to dev/louisa-may-alcott October 14, 2019 23:00
@beckjake beckjake marked this pull request as ready for review October 14, 2019 23:00
@beckjake
Copy link
Contributor Author

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

@beckjake beckjake merged commit 73d0308 into dev/louisa-may-alcott Oct 15, 2019
@beckjake beckjake deleted the feature/avoid-osx-flaky-rpc branch October 15, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants