Add "partitions" to the adapter specific config (#2256) #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And tests, of course
beckjake
force-pushed
the
fix/add-partitions-bq-config
branch
from
7290d66
to
c63f60e
Compare
beckjake
requested review from
drewbanin and
jtcohen6
and removed request for
drewbanin
jtcohen6
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
LGTM
There's two different uses for the partitions config in dbt-bigquery right now:
- Creating ingestion-time partitioned tables, added in 0.10.0
- An optional behavior of the
insert_overwriteincremental strategy, added in 0.16.0
The tests added in this PR are largely checking the first feature, which we don't generally recommend in our modeling anymore. BigQuery's recent development has prioritized column partitioned tables over ingestion-time partitioned tables. That said, dbt has supported creating date-partitioned tables for several years, and unless we're about to stop supporting it, adding tests is A Good Thing.
|
The key of the test here is "does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2256
Description
Add partitions to the BigQuery adapter-specific config, and test that the config works.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.