Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing get_missing_var from ParseVar class #3358

Closed
wants to merge 1 commit into from
Closed

removing get_missing_var from ParseVar class #3358

wants to merge 1 commit into from

Conversation

jpmmcneill
Copy link
Contributor

@jpmmcneill jpmmcneill commented May 15, 2021

resolves #3320

Description

Gets rid of a function that only returned None that appears to be causing the compiler having issues raising descriptive exceptions when loops and vars are involved.

Getting rid of this seems to get everything working for me (ie. get more verbose errors showing up - I have tested this in jaffle_shop). I have no context as to why this odd return None function was added here so there might be an some conditional logic to make sure that the original case isn't being blown out of the water here.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot
Copy link

cla-bot bot commented May 15, 2021

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @jpmmcneill

@jpmmcneill jpmmcneill marked this pull request as draft May 15, 2021 11:44
@jpmmcneill
Copy link
Contributor Author

The initial naive change has lead to unit tests failing. I'll look into the reasons for failure and update below if I make progress

@jpmmcneill
Copy link
Contributor Author

Closing this issue for the moment, I may come back to it in future.

@jpmmcneill jpmmcneill closed this Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Var does not exist exception not being caught
1 participant