Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work in progress #374

Closed
wants to merge 1 commit into from
Closed

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented Apr 11, 2017

This fixes #373. This branch is functionally about what i think is necessary here, but there's a decent amount of cleanup to do before we can merge this.

@cmcarthur can you think of any way to reliably discover refs without injecting ourselves into the lexer? I think once we get any higher up the chain than that, we'll lose the ability to traverse conditional branches.

This does not work if the thing passed to ref is a variable, eg:

{% models = ['model_1', 'model_2'] %}

{% for model in models %}
  select * from {{ ref(model) }} union all
{% endfor %}
....

@drewbanin drewbanin closed this Apr 12, 2017
@drewbanin drewbanin deleted the feature/parse-refs-globally branch April 12, 2017 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant