[#3940] Use flags.PROFILES_DIR in a few more places #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahwicz
approved these changes
Sep 23, 2021
gshank
force-pushed
the
fix_flags_profiles_dir
branch
from
2664d9e
to
ccaacf6
Compare
gshank
force-pushed
the
fix_flags_profiles_dir
branch
from
ccaacf6
to
fda17b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3940
Description
There were a few places that were not using flags.PROFILES_DIR and were still using args.profiles_dir. The test infrastructure relied on the profiles_dir attribute in the args structure. This fixes the remaining args.profiles_dir in core code and modifies some of the test utilities to use flags.PROFILES_DIR.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.