[#3689] Fix filesystem searcher and tests that mock it #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
force-pushed
the
fix_filesystem_searcher
branch
from
74d1736
to
d0171b0
Compare
jtcohen6
reviewed
Nov 12, 2021
There was a problem hiding this comment.
Nice one!
Could we turn on unit tests for 3.9 in CI, to verify this works (and have full testing on py39 going forward)?
dbt-core/.github/workflows/main.yml
Line 80 in 0722922
gshank
force-pushed
the
fix_filesystem_searcher
branch
from
d0171b0
to
28d940b
Compare
kwigley
approved these changes
Nov 15, 2021
jtcohen6
approved these changes
Nov 15, 2021
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3689
Description
With Python 3.9 we were getting a unit test failure which was due to a leftover mock from a different test. The reason for this isn't totally clear; it might possibly be a Python bug, but isn't worth chasing down. This converts the filesystem searcher to a simple function and changes the mock to explicitly be on the function used in test_graph.py.
Checklist
CHANGELOG.mdand added information about my change