Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed misspellings, typos, and duplicated words #4545

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Fixed misspellings, typos, and duplicated words #4545

merged 2 commits into from
Feb 22, 2022

Conversation

kazanzhy
Copy link
Contributor

@kazanzhy kazanzhy commented Jan 3, 2022

Fixed misspellings, typos, and duplicated words

@cla-bot
Copy link

cla-bot bot commented Jan 3, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @kazanzhy

@kazanzhy
Copy link
Contributor Author

kazanzhy commented Jan 4, 2022

I'm already signed CLA

@kazanzhy kazanzhy marked this pull request as draft January 4, 2022 10:22
@kazanzhy kazanzhy marked this pull request as ready for review January 4, 2022 10:22
@leahwicz
Copy link
Contributor

leahwicz commented Jan 4, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Jan 4, 2022
@cla-bot
Copy link

cla-bot bot commented Jan 4, 2022

The cla-bot has been summoned, and re-checked this pull request!

@leahwicz
Copy link
Contributor

leahwicz commented Jan 4, 2022

Thanks @kazanzhy for the contribution! We really appreciate the help!

@leahwicz
Copy link
Contributor

leahwicz commented Jan 4, 2022

@kazanzhy could you please do one last update and that would be adding your change to the Changelog file please under the 1.1.0 section? We would like to make sure you get credit for the change

leahwicz
leahwicz reviewed Jan 4, 2022
View reviewed changes
test/unit/utils.py Outdated Show resolved Hide resolved
@kazanzhy
Copy link
Contributor Author

kazanzhy commented Jan 4, 2022

changelog is updated

I've started to learn dbt in https://courses.getdbt.com and decided to look at how is project built.
I'm going to contribute how I can.
@leahwicz thanks for your support

@kazanzhy kazanzhy requested review from a team as code owners February 1, 2022 22:53
@kazanzhy kazanzhy requested a review from a team February 1, 2022 22:53
@kazanzhy kazanzhy requested a review from a team as a code owner February 1, 2022 22:53
@kazanzhy kazanzhy requested review from gshank and nathaniel-may and removed request for a team February 1, 2022 22:53
@gshank gshank merged commit 8f50eee into dbt-labs:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahwicz leahwicz leahwicz approved these changes

@gshank gshank Awaiting requested review from gshank gshank was automatically assigned from dbt-labs/core-group

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may nathaniel-may was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kazanzhy @leahwicz @gshank