-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop support for Python 3.7.0 and 3.7.1 #4585
Conversation
Should this go in for |
@jtcohen6 that's correct. I can see good reasons for including in either version:
Which version would you like this to go in? EDIT: I just realized that the second option might be moot. People on the affected versions can't even use dbt since |
I buy it! |
@leahwicz we could also backport this to 0.21 since we know that version is affected as well, but I don't think patches were in the plan for versions prior to 1.0. |
@nathaniel-may we only want to patch 0.21 for security bugs at this point so let's not backport this to that release. For |
That's fair. Normally I'd argue that this fixes a bug because it would prevent users from issuing Happy to wait till |
@nathaniel-may I realized we actually want this change to I'm fine with the reasoning above, so I switched #4584 to the Could we make sure this gets a changelog entry for |
resolves #4584
Running dbt v1.0.0 and v0.21 (and possibly other dbt versions) with these Python versions causes a Python exception to be thrown. This disallows installing dbt with when running pip with these Python versions.
Checklist
CHANGELOG.md
and added information about my change