include directory README #4685
include directory README #4685
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
| @@ -0,0 +1,7 @@ | |||
| kind: Docs | |||
There was a problem hiding this comment.
@jtcohen6 do we want Docs to just be documentation changes generally or strictly for dbt-docs changes?
Apart from this PR - it might be worth updating the changie README with more details on each change type (ie, be sure to add details of what will break on a breaking change).
There was a problem hiding this comment.
just my opinions:
- original intent with
Docswas "strictly for dbt-docs changes" - generally I think a change like this can be
Skip changelog— README, reflected in GitHub only, no real change to the functionality of installeddbt-core
There was a problem hiding this comment.
I was going for a changelog entry for all the things! But it makes sense that this is a good candidate for Skip Changelog. @McKnight-42 can you make that happen?
There was a problem hiding this comment.
Manually deleted draft changie file and added label.
* start of a README for the include directory * minor updates * minor updates after comments from gerda and emily * trailing space issue? * black formatting * minor word change * typo update * minor fixes and changelog creation * remove changelog
resolves #4968
Description
Writing up a README for the include directory giving brief description of each folder or file in top level.
Checklist
CHANGELOG.mdand added information about my change