Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-271] [Feature] not_null test selects column instead of * #4777

Merged
merged 6 commits into from
Mar 10, 2022
Merged

[CT-271] [Feature] not_null test selects column instead of * #4777

merged 6 commits into from
Mar 10, 2022

Commits on Feb 23, 2022

  1. Only select target column for not_null test

    @willbowditch
    willbowditch committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    7e0fbd3 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. If storing failures include all columns in the select, if not, only s… 

    …elect the column being tested

It's desirable for this test to include the full row output when using --store-failures. If the query result stored in the database contained just the null values of the null column, it can't do much to contextualize why those rows are null.
    @willbowditch
    willbowditch committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    bd3a994 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @willbowditch
    willbowditch committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    281d805 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Merge branch 'main' into wb/not-null-col

    @willbowditch
    willbowditch committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    828e662 View commit details
    Browse the repository at this point in the history

  2. chore: update changelog using changie

    @willbowditch
    willbowditch committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    3778789 View commit details
    Browse the repository at this point in the history

  3. Revert "Update changelog" 

    This reverts commit 281d805.
    @willbowditch
    willbowditch committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    cf4775f View commit details
    Browse the repository at this point in the history