-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compliation and cache tracking #4912
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
core/dbt/tracking.py
Outdated
track( | ||
active_user, | ||
category="dbt", | ||
action="runnable", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we call this runnable_timing
(or runnable_task_startup_timing
) for better clarity/discoverability down the line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChenyuLInx Nice work! Excited to have this in the beta, so we can start validating the data in advance of the final release.
One thing comes to mind: If we end up merging #4860, it would super valuable to track whether a user has opted into the flag/config added there (cache_selected_only
). I don't think we have any general-purpose tracking for all "global" config values on the invocation.
Since that PR isn't yet merged, it doesn't really make sense to support it in this PR. We can follow up with a new field in the schema and in the tracking event calls.
resolves #4625
Description
Add tracking for compilation time and adapter cache population time. The compilation time and adapter cache time will be sent to snowplow events table as separate event under the action
runnable
.Checklist