-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmetic changelog/changie fixups #4944
Conversation
@@ -28,7 +28,7 @@ custom: | |||
type: int | |||
minLength: 4 | |||
footerFormat: | | |||
Contributors: | |||
### Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is a no-look pass, I could be wildly off the mark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's easy to test all your changes work as expected!
Run this to print out what the generated yaml file will be:
changie batch 1.1.0 --dry-run --include '1.1.0'
--dry-run
just prints out what would be generated and doesn't actually create a file or delete any yaml and --include
will include the yaml files in that directory.
Note: Two new changes have been merged in since the release (2 files exists in .changes/unreleased
) so those will be erroneously included. Since it's not creating the files it doesn't matter. This command should be enough to eyeball that the file is generated like you expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realized I needed to update my installed version of changie
! after that, works like a charm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
resolves #4943
Contributors:
→### Contributors
(feels right)After merging: Update v1.1.0b1 release notes