-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version output and logic #5029
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @stu-k, this represents a meaningful improvement and refactor of the code! I left a handful of comments. Only one is a true blocker (Major.Minor
compatibility comparison). The rest are smaller + cosmetic only.
There's one bigger question about the right way to present upgrade info when it's relevant to core + many plugins. I think it would be worth a more generic message that prints https://docs.getdbt.com/dbt-cli/install/overview
once, rather than once for each.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Very solid refactor of the code! Left one nitpick that's only my personal preference. Can also leave it out if you feel like the current way is easier to read!
Looks like there's a mypy error, otherwise looks good! |
@ChenyuLInx That error doesn't have to do with anything I added or changed. EDIT: Whoops totally caused by my changes. |
Yes, looks like this line is not even touched. I am not sure why mypy complains about it either. But when I run mypy on main it doesn't have any error. We will have to fix it or ignore this to get the workflow pass |
Update version output and logic
Update version output and logic
resolves #4724
Description
Most notably, updated the logic for displaying plugin information as follows:
The tests capture the intended code paths, please review them for more information about outputs.
Checklist