Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add itertools to modules #5140

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Add itertools to modules #5140

merged 2 commits into from
Apr 26, 2022

Conversation

bd3dowling
Copy link
Contributor

@bd3dowling bd3dowling commented Apr 24, 2022

resolves: #5130

Description

Adds itertools to modules Jinja-"namespace" for usage as global functions.

Checklist

@bd3dowling bd3dowling requested review from a team and leahwicz as code owners April 24, 2022 12:26
@bd3dowling bd3dowling requested a review from emmyoop April 24, 2022 12:26
@cla-bot cla-bot bot added the cla:yes label Apr 24, 2022
jtcohen6 and others added 2 commits April 24, 2022 13:30
* Update contributing guide

* Update issue + PR templates

* Stalebot for all issues, no exceptions

* Update links

* Missed one

* PR feedback
@bd3dowling bd3dowling changed the title GH hygiene: contributing guide, templates, stalebot (#4967) Add itertools to modules Apr 24, 2022
@emmyoop emmyoop removed request for a team and leahwicz April 25, 2022 15:59
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @bd3dowling! This looks great. Thanks for opening up the related docs issue as well.

Comment on lines +82 to +83
# Excluded dropwhile, filterfalse, takewhile and groupby;
# first 3 illogical for Jinja and last redundant.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this explanation.

@emmyoop emmyoop merged commit f87c781 into dbt-labs:main Apr 26, 2022
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request May 20, 2022
* GH hygiene: contributing guide, templates, stalebot (dbt-labs#4967)

* Update contributing guide

* Update issue + PR templates

* Stalebot for all issues, no exceptions

* Update links

* Missed one

* PR feedback

* Update CHANGELOG

Co-authored-by: Jeremy Cohen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-539] [Feature] Add zip and modules.itertools to BaseContext
3 participants