Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the target name to be set in profile_template.yml #5184

Merged
merged 4 commits into from
May 3, 2022
Merged

Allow the target name to be set in profile_template.yml #5184

merged 4 commits into from
May 3, 2022

Conversation

alexrosenfeld10
Copy link
Contributor

@alexrosenfeld10 alexrosenfeld10 commented Apr 28, 2022

resolves #5179

Description

As per title, this allows a target key to be set in profile_template.yml, instead of being hardcoded to dev. I borrowed an existing test case because this is a pretty simple change. If that's not alright I'm happy to add a dedicated test if that's seen as necessary.

I also fixed a few random typos I found while I was setting up locally. If desired I can certainly pull those out into a separate PR.

Checklist

Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iknox-fa iknox-fa merged commit a2e040f into dbt-labs:main May 3, 2022
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request May 20, 2022
* Allow the target name to be set in profile_template.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-569] [Feature] Allow profile_template to prompt and name a target
3 participants