Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove script for snowflake oauth reset as its been moved to snowflake #5362

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Jun 10, 2022

#5361

Description

moved snowflake specific script to snowflake, so we should be able to remove it from core.

Checklist

@cla-bot cla-bot bot added the cla:yes label Jun 10, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@McKnight-42 McKnight-42 self-assigned this Jun 10, 2022
@McKnight-42 McKnight-42 marked this pull request as ready for review June 10, 2022 16:36
@McKnight-42 McKnight-42 requested a review from a team as a code owner June 10, 2022 16:36
@@ -0,0 +1,7 @@
kind: Under the Hood
body: removed script meant for snowflake to snowflake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Render unto Snowflake, that which is Snowflake's :)

Meta comment: since this change doesn't affect any code that's part of an actual dbt software distribution, I'd generally opt for a Skip changelog label here. But no harm in having one

@McKnight-42 McKnight-42 merged commit 309efaa into main Jun 14, 2022
@McKnight-42 McKnight-42 deleted the mcknight/remove-snowflake-oauth-script branch June 14, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants