[Fix]: remove duplicate key checking #5403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
leahwicz
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
This just looks like a revert of https://github.com/dbt-labs/dbt-core/pull/5146/files so LGTM!
gshank
approved these changes
Jun 23, 2022
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* remove duplicate key checking * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily resolves #5331 and #5268
Description
Fallback PR to remove duplicate key checking which is causing some bugs in 1.2.0a1.
Checklist
changie newto create a changelog entry