Remove trailing slashes from source paths (#6102)

[jmg-duarte]

resolves #6102

Description

Paths like "models" and "models/" are the same but were resolved as different. Leading to issues when seemingly equivalent (but different) paths were used in (for example) seeds and models.

The following example would detect the same files twice.

model-paths:
  - models
seed-paths:
  - models/

Checklist

• I have read the contributing guide and understand what's expected of me
• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
• I have run changie new to create a changelog entry

[peterallenwebb]

@jmg-duarte, thanks for this contribution.

It appears that to make mypy happy, which is necessary before merge, you will need to avoid assigning the paths variable twice, but with objects of different types. Overall the fix makes sense to me, and I'll keep an eye out for your update so that we can quickly merge.

[jmg-duarte]

Hey @peterallenwebb, I'm having some trouble updating the branch because I deleted the forked repo a while ago by mistake and haven't been able to push changes to the branch. I've followed guides but to no avail. I've also contacted GitHub support to see if I can avoid creating a new PR but if you feel this is important enough, I can go one to close this one and create a new branch.

[peterallenwebb]

@jmg-duarte That would be great! If don't feel like going through all the trouble, I can also get this change in on your behalf with no further effort on your part, just let me know.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: José Duarte.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[jmg-duarte]

@peterallenwebb GitHub support was super helpful and I got it working. I've applied the changes, let me know if there is something I should update further!

[emmyoop]

A few formatting issues and you'll need to resolve the conflict. Then this should be good to merge in!

[jmg-duarte]

A few formatting issues and you'll need to resolve the conflict. Then this should be good to merge in!

Rebasing over main was enough, thank you! Resolved and ready for review!

[emmyoop]

Almost there! Just need to fix mypy.

[emmyoop]

my doesn't like that you change the type of paths here

Suggested change

	paths = map(lambda s: s.rstrip("/"), paths)
	return list(set(paths))
	paths_stripped = map(lambda s: s.rstrip("/"), paths)
	return list(set(paths_stripped))

[jmg-duarte]

I did this before, with the constant updates to the underlying code I must've messed up the rebase. Let me fix that

[emmyoop]

Clicked the wrong button, meant to request a change!

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: José Duarte.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[emmyoop]

@jmg-duarte almost there! black now fails on a formatting issue. If you run pre-commit (pre-commit run after installing it as described in the contributing doc), it will make the fixes for you. Alternatively, you can check out the failing tests and manually fix the formatting issue.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: José Duarte.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[jmg-duarte]

Should be working now. My VSCode applied isort which in turn f'd up the black formatting. Thank you for the patience

[emmyoop]

Looks great! Thanks @jmg-duarte for the contribution. I'll get it merged in!