-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow duplicate refable node names across packages #7374
Conversation
…se AmbiguousResourceNameError in find_unique_id_for_package
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
26d48d4
to
1c3b5b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! It's actually surprising that it didn't take more than this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!! took it for a spin, & it spins
shall we queue up #1269 to close? :)
Ah, something that's still not working: attaching yaml properties to the correct node in the case of duplicates. (This was also the blocker to merging #3053 a few years ago.) # packages.yml
packages:
- local: package_a
- local: package_b -- package_a/models/my_model.sql
select 1 as id # package_a/models/schema.yml
models:
- name: my_model
description: My cool model -- package_b/models/my_model.sql
{{ config(alias="something_else") }}
select 1 as id -- models/another_model.sql
select * from {{ ref('package_a', 'my_model') }}
Goal: It should be possible to define yaml properties for a model within the same package as that model. (In the future, we could look to support "overrides" of the package resource from the root project, similar to how we do with |
ec62766
to
1fa3608
Compare
@jtcohen6 - Pushed up a fix for defining yaml properties on a model within the same package as that model. |
resolves: #7446
resolves: #1269
Description
Checklist
changie new
to create a changelog entry