Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-3013] Fix parsing of window_groupings #8454

Merged
merged 3 commits into from
Aug 18, 2023
Merged

[CT-3013] Fix parsing of window_groupings #8454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db7909a
Update semantic model parsing tests to check measure non_additive_dim…
QMalcolm Aug 18, 2023
8c256b0
Make `window_groupings` default to empty list if not specified on `no…
QMalcolm Aug 18, 2023
ba5e1e7
Add changie doc for `window_groupings` parsing fix
QMalcolm Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20230818-095348.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Ensure parsing does not break when `window_groupings` is not specified for `non_additive_dimension`
time: 2023-08-18T09:53:48.154848-07:00
custom:
Author: QMalcolm
Issue: "8453"
2 changes: 1 addition & 1 deletion core/dbt/contracts/graph/unparsed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ class UnparsedEntity(dbtClassMixin):
class UnparsedNonAdditiveDimension(dbtClassMixin):
name: str
window_choice: str # AggregationType enum
window_groupings: List[str]
window_groupings: List[str] = field(default_factory=list)


@dataclass
Expand Down
8 changes: 7 additions & 1 deletion tests/functional/semantic_models/test_semantic_model_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@
agg_time_dimension: ds
agg_params:
percentile: 0.99
- name: test_non_additive
expr: txn_revenue
agg: sum
non_additive_dimension:
name: ds
window_choice: max

dimensions:
- name: ds
Expand Down Expand Up @@ -125,7 +131,7 @@ def test_semantic_model_parsing(self, project):
semantic_model.node_relation.relation_name
== f'"dbt"."{project.test_schema}"."fct_revenue"'
)
assert len(semantic_model.measures) == 5
assert len(semantic_model.measures) == 6
# manifest should have one metric (that was created from a measure)
assert len(manifest.metrics) == 2
metric = manifest.metrics["metric.test.txn_revenue"]
Expand Down
Loading