Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass package_name when looking up versioned model node during parsing #8494

Closed
wants to merge 1 commit into from

Conversation

MichelleArk
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Aug 24, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #8494 (fe79715) into main (d18a74d) will decrease coverage by 3.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8494      +/-   ##
==========================================
- Coverage   86.35%   83.08%   -3.27%     
==========================================
  Files         174      174              
  Lines       25573    25573              
==========================================
- Hits        22083    21248     -835     
- Misses       3490     4325     +835     
Flag Coverage Δ
integration 83.08% <ø> (-0.13%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/parser/schemas.py 92.75% <ø> (ø)

... and 65 files with indirect coverage changes

@MichelleArk
Copy link
Contributor Author

closing in favor of: #8488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant