Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge source meta and table meta on SourceDefinition.meta #9723

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Mar 1, 2024

resolves #9766

Problem

SourceDefinition.meta only includes table-level meta, which means it is not usable via the RelationConfig protocol to access source-level meta.

Solution

  • Merge source-level and table-level meta into SourceDefinition.meta, with table-level taking precedence
  • Preserve SourceDefinition.source_meta to keep this change backward-compatible

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.13%. Comparing base (c501d71) to head (cf393cd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9723      +/-   ##
==========================================
+ Coverage   88.11%   88.13%   +0.01%     
==========================================
  Files         178      178              
  Lines       22479    22480       +1     
==========================================
+ Hits        19807    19812       +5     
+ Misses       2672     2668       -4     
Flag Coverage Δ
integration 85.51% <100.00%> (+0.01%) ⬆️
unit 62.74% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk marked this pull request as ready for review March 15, 2024 20:14
@MichelleArk MichelleArk requested a review from a team as a code owner March 15, 2024 20:14
@MichelleArk MichelleArk merged commit 65b366b into main Mar 15, 2024
58 checks passed
@MichelleArk MichelleArk deleted the merge-source-meta-meta branch March 15, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SourceDefinition.meta should represent merged base meta and table_meta
2 participants