Add more package validation #9986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9986 +/- ##
==========================================
+ Coverage 88.17% 88.19% +0.02%
==========================================
Files 181 181
Lines 22614 22632 +18
==========================================
+ Hits 19939 19961 +22
+ Misses 2675 2671 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
emmyoop
force-pushed
the
er/packages-validation
branch
from
f64fcf5
to
1c66b85
Compare
…986-packages-validation
ChenyuLInx
reviewed
Apr 24, 2024
core/dbt/contracts/project.py
Outdated
| if isinstance(package, dict): | ||
| if package.get("package") == "": | ||
| raise ValidationError( | ||
| "A package is missing the value. It is a required property." |
There was a problem hiding this comment.
Should we add some more detailed message here to help folks narrow down the problem since we already know what type is missing value here?
ChenyuLInx
approved these changes
Apr 24, 2024
emmyoop
commented
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9985
Problem
dbt hangs when packages have empty values. This is generally not intentional but the result of empty env-vars.
Solution
Add validation
Checklist