Add property: "delimiter" in seed-config #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave-connors-3
requested changes
Oct 21, 2024
There was a problem hiding this comment.
hey @kouta-fujimura ! thanks for the PR -- generally we are only amending the jsonschemas under the latest/ directory, but since you did the work here, I'm happy to merge these in to 1.7 as well!
It looks like we'll need to also edit latest/dbt_project-latest.json to make sure there's support for delimiter there as well. Additionally, if you could revert the change to the dbt_project.json at the root of the repo, that would be great! those are legacy files that we don't update.
…t-{1.7|latest}.json
|
@dave-connors-3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.getdbt.com/reference/resource-configs/delimiter
dbt supports delimiter from v1.7, but currenly not exists in two files.