-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid truncating Redshift model names with more than 63 characters #147
Conversation
@Goodkat Responding to your comment in the issue:
We have access to a Redshift cluster running in CI. I think it would be simplest to add a functional test with the reproduction case from the original issue. In that example, the two models were named:
|
@jtcohen6 I found out the existing tests for Redshift model names "my_name_is_XX_characters...": We can extend them with the new entries for 127 characters or add there the cases from the original issue. What do you think? |
This reverts commit d2cff85.
And who maintains the |
@Goodkat Example of how to update the |
Thanks for taking a crack at this @Goodkat. Do you feel confident writing a test for this? I see you've got a good looking model for testing this but you'll need a Python driver. I also appreciate this is time sensitive. Happy to drive this over the finish line too if need be. 🏎️ |
Thanks @VersusFacit for your comments. I just found and extended the existing test models with the new case for 127 characters. I am not sure if it is enough for testing this. |
Hitting you back. I wanted to add a negative test to make sure the exception handling worked -- it does -- and in my PR, I also added tests in our new framework. I'm closing this one out, but because I cherry picked your commits, your work will be rightfully highlighted in the history upon merge 💥 |
resolves #5586
Description
Because the dbt-redshift adapter inherits from dbt-postgres, it will use any new dbt-postgres methods/macros unless told otherwise. However Redshift allows relation names up to 127 characters (docs), so it doesn't require the same complex handling at the 63-character mark as it is done for Postgres.
Checklist
CHANGELOG.md
and added information about my change to the "dbt-redshift next" section.