init push of unique key test reformat for redshift #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@McKnight-42 I think you'll need to update this line: dbt-redshift/dev_requirements.txt Line 4 in 162dc30 To point to the branch open in dbt-labs/dbt-core#4958: (Unless we decide we want to merge the core PR first. IMO it's it's better to keep it open, to enable rapid iteration while working across the adapters, then merge only once they're all passing) |
… changing dev_requirements install)
4 tasks
abbywh
pushed a commit
to abbywh/dbt-redshift
that referenced
this pull request
Oct 11, 2023
* init push of unique key test reformat for redshift * updating import path * add changelog entry * changing pointer to try and get tests to pass in ci * removing changelog entry (per disucssion these prs don't need one and changing dev_requirements install)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of CT-375
Description
Working on getting the unique_key tests to work on redshift in new format
TODO:
get tests workingremove old testupdate changelogChecklist
CHANGELOG.mdand added information about my change to the "dbt-redshift next" section.