Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance test show objects vs show terse objects #1046

Closed
wants to merge 9 commits into from

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented May 15, 2024

Problem

We are considering moving the list_relations_without_caching call to use show objects instead of show terse objects given the changes in the Snowflake 2024_03 bundle.

Solution

Create tests that overwrite the specific call with both methods and run it several times to get a benchmark. Compare the benchmarks and make a decision. This PR may never be merged, but it does serve the purpose of sharing this work. We can decide if the benchmark tests are worth merging.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this May 15, 2024
@cla-bot cla-bot bot added the cla:yes label May 15, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant