-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-2819] default__alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation #1108
Draft
McKnight-42
wants to merge
10
commits into
main
Choose a base branch
from
mcknight/ct-2819
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
snippets from a test runs logs: create or replace transient table DBT_TEST.test17205532125894120837_test_incremental_on_schema_change.src_artists
as
(
select convert_timezone('UTC', current_timestamp()) as inserted_at, 'john' as name
); | INSERTED_AT | NAME |
| -------------------- | ---- |
| 2024-07-09 19:26:... | john | create or replace transient table DBT_TEST.test17205532125894120837_test_incremental_on_schema_change.src_artists
as
(
-- add a non-zero version to the end of the command to get a different version:
-- --vars "{'version': 1}"
select convert_timezone('UTC', current_timestamp()) as inserted_at, 'john' as Name, 'engineer' as "Job"
); | INSERTED_AT | NAME | Job |
| -------------------- | ---- | -------- |
| 2024-07-09 19:26:... | john | |
| 2024-07-09 19:27:... | john | engineer | |
McKnight-42
changed the title
Snowflake alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation
[CT-2819] default__alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #dbt-labs/dbt-adapters#250
docs dbt-labs/docs.getdbt.com/#
Problem
user raised issue around "While working with DBT incremental config: on_schema_change='append_new_columns'
The append new columns flag is not able to capture the correct case-sensitive column name and add it to the incremental table causing the run to fail."
they stated they were using snowflake.
Solution
add a new test to dbt-adapters-tests to check that column quoting case sensitivity is expressed correctly, update all macros in adapters as needed if they do not use the default implementation and test default implementing macros to see if we need to update the dbt-adapters macro as well.
Todo:
Checklist