Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standardize_grants_dict to handle potential case mismatches in grants table response #1087

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lamalex
Copy link

@lamalex lamalex commented Aug 3, 2024

Match case to column names returned rather than hardcoding.
Fixes: #1086

resolves #1086
docs dbt-labs/docs.getdbt.com/#

Problem

DBT crashing due to column case mismatch in response from databricks on show grants statement.

Solution

Match column name case to response rather than hardcoding names.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

…in grants table response

Match case to column names returned rather than hardcoding.
Fixes: dbt-labs#1086
@lamalex lamalex requested a review from a team as a code owner August 3, 2024 16:13
Copy link

cla-bot bot commented Aug 3, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @lamalex

@lamalex
Copy link
Author

lamalex commented Aug 3, 2024

Signed!

Copy link

cla-bot bot commented Aug 3, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @lamalex

@lamalex
Copy link
Author

lamalex commented Aug 3, 2024

signed again!

@amychen1776 amychen1776 added the grants Issues related to dbt's grants functionality label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grants Issues related to dbt's grants functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Crash when dbt runs show grants statement due to column name capitalization mismatch
2 participants