Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolating distribution testing #1105

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Conversation

leahwicz
Copy link
Contributor

@leahwicz leahwicz commented Sep 11, 2024

resolves #1069

Problem

We validate wheel and source distributions in the same environment during the build validation step. This led to issues documented here dbt-labs/dbt-core#10465.

Solution

This is the same solution as what we did in dbt-snowflake first: dbt-labs/dbt-snowflake#1161
This is to bring parity to the other repos as well.

This is a test run of the Action running with the installation and testing of wheels and source distributions split into separate Actions Jobs that isolate them from one another: https://github.com/leahwicz/dbt-spark/actions/runs/10821352615

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@leahwicz leahwicz requested a review from a team as a code owner September 11, 2024 23:49
@cla-bot cla-bot bot added the cla:yes label Sep 11, 2024
@mikealfare mikealfare self-assigned this Oct 11, 2024
@mikealfare mikealfare merged commit d72693b into dbt-labs:main Oct 18, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the build check workflow
2 participants