-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --store-failures #233
Merged
Merged
Fix --store-failures #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also blocked by #231, i.e. upgrading the
|
leahwicz
approved these changes
Oct 15, 2021
jtcohen6
force-pushed
the
fix/test-store-failures
branch
from
October 15, 2021 13:39
189f081
to
de96a8a
Compare
sungchun12
reviewed
Oct 15, 2021
sungchun12
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super impressive how fast you moved on this based on a candid slack thread. LGTM
jtcohen6
added a commit
that referenced
this pull request
Oct 18, 2021
* Fix --store-failures * Add chnagelog entry * Maybe this? * Fix indentation * Class inheritance, silly
jtcohen6
added a commit
that referenced
this pull request
Oct 18, 2021
* Fix --store-failures (#233) * Fix --store-failures * Add chnagelog entry * Maybe this? * Fix indentation * Class inheritance, silly * Add support for on_schema_change (#229) * Add support for on_schema_change * Add changelog note * add persist_doc call to incremental model with tests (#234) * add persist_doc call to incremental model with tests * update changelog * add whatis to test for incremental * Reorg changelog Co-authored-by: Binh Pham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #232
Backport to
0.21.latest
after. (Unfortunately, this will just be broken in v0.20.x)Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.