Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit hook tooling. #346

Merged
merged 3 commits into from
May 11, 2022
Merged

Add commit hook tooling. #346

merged 3 commits into from
May 11, 2022

Commits on May 2, 2022

  1. Add commit hook tooling.

    @VersusFacit
    VersusFacit committed May 2, 2022
    Configuration menu
    Copy the full SHA
    0a2411c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Make pre commit code changes (#345) 

    * Run pre commit hooks and do some minor type editing.

* Refactor exception function using accurate type specs.

* Upgrade the mypy version in order to use TypeAlias-es.

* Upgrade the mypy version in the worfklow. Fix bug introduced by using str's instead of Optional[str]'s

Co-authored-by: Mila Page <[email protected]>
    @VersusFacit
    VersusFacit and VersusFacit committed May 11, 2022
    Configuration menu
    Copy the full SHA
    8a659a7 View commit details
    Browse the repository at this point in the history

  2. Address code review comments and remove integration test command sinc… 

    …e there are multiple ways we can run tests in spark.
    @VersusFacit
    VersusFacit committed May 11, 2022
    Configuration menu
    Copy the full SHA
    f30a2c9 View commit details
    Browse the repository at this point in the history