Add commit hook tooling. #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make pre commit code changes (#345) * Refactor exception function using accurate type specs. * Upgrade the mypy version in order to use TypeAlias-es. * Upgrade the mypy version in the worfklow. Fix bug introduced by using str's instead of Optional[str]'s * Address code review comments: Remove integration test command since there are multiple ways we can run tests in spark.
4 tasks
jtcohen6
approved these changes
May 13, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #292 . Overrides #297
Description
Add pre-commit tooling to this repo. The code here is a product of prior PRs. Changelog is included here.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-spark next" section.