Finish Constraint Support for Spark #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterallenwebb
commented
May 24, 2023
| "violate the new NOT NULL constraint", | ||
| "(id > 0) violated by row with values:", # incremental mats | ||
| "DELTA_VIOLATE_CONSTRAINT_WITH_VALUES", # incremental mats | ||
| "NOT NULL constraint violated for column", | ||
| ] |
There was a problem hiding this comment.
The new error messages were needed here, as it appears the messages coming from Databricks have changed slightly, and some of the messages were also truncated differently.
|
Heads-up @peterallenwebb: the pull request description needs to be something like this to close multiple issues: Otherwise, it will only auto-close the first issue, and the subsequent issue(s) will be left open. |
|
@peterallenwebb Nevermind my comment about syntax for |
McKnight-42
approved these changes
May 24, 2023
|
@peterallenwebb nevermind my nevermind 😅 -- from the changelog entry, it appears that you meant #657 instead of #655? In that case, the PR description should be updated to: |
dbeatty10
previously requested changes
May 24, 2023
Co-authored-by: Doug Beatty <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
* CT-2223: Add CONSTRAINT_SUPPORT mapping to adapter implementation * CT-2223: Model constraints implemented for spark * CT-2223: Add unit test * CT-2223: Exclude test not applicable to spark * CT-2223: Another unit test fix. * CT-2223: Final (?) unit test fix * CT-2223: Final (??) unit test fix * Update .changes/unreleased/Features-20230427-123135.yaml Co-authored-by: Doug Beatty <[email protected]> --------- Co-authored-by: Doug Beatty <[email protected]> (cherry picked from commit 4f1039d)
MichelleArk
pushed a commit
that referenced
this pull request
Jun 6, 2023
* CT-2223: Add CONSTRAINT_SUPPORT mapping to adapter implementation * CT-2223: Model constraints implemented for spark * CT-2223: Add unit test * CT-2223: Exclude test not applicable to spark * CT-2223: Another unit test fix. * CT-2223: Final (?) unit test fix * CT-2223: Final (??) unit test fix * Update .changes/unreleased/Features-20230427-123135.yaml Co-authored-by: Doug Beatty <[email protected]> --------- Co-authored-by: Doug Beatty <[email protected]> (cherry picked from commit 4f1039d) Co-authored-by: Peter Webb <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #656, resolves #657
Description
Add model-level constraint support to Spark
Checklist
changie newto create a changelog entry