Update adaptors.sql to use tblproperties macro

[etheleon]

resolves #865
resolves #190
docs dbt-labs/docs.getdbt.com/#

Problem

tblproperties clause macro is not used when creating tables. Add macro to adaptor.sql

Solution

Add macro

Checklist

• [ x] I have read the contributing guide and understand what's expected of me
• [x ] I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

[etheleon]

see discussion #847

[JCZuurmond]

@etheleon : Thanks for the contribution! I added a suggestion to align the code with the other clauses:

[JCZuurmond]

@etheleon : Could you rename the dbt_spark_tblproperties_clause to spark__tblproperties_clause and create a similar pattern as for the other clauses?

{% macro tblproperties_clause() %}
  {{ return(adapter.dispatch('tblproperties_clause', 'dbt')()) }}
{%- endmacro -%}

{% macro spark__tblproperties_clause() %}
...
{%- endmacro -%}

[etheleon]

sure, I've submitted my commit

[etheleon]

@JCZuurmond if you have time for this review

[JCZuurmond]

LGTM! Thanks for fixing this

[JCZuurmond]

@Fleid: Could you merge this PR?

[martelli]

I had the same problem and fixed it in a similar way locally. My question is then: why add it here (seed.sql) and not in adapters.sql directly under macro spark__create_table_as?
It seems it would be a more generic change, no?

[JCZuurmond]

You are right, @martelli. It makes more sense to put it in the spark__create_table_as. I assumed it was there, did not read correctly that the change was done in the `seed.sql.

[martelli]

@JCZuurmond Ok. Since I had the fix ready, I've completed a parallel pull request. If this one gets updated and landed, I'll discard mine.

[etheleon]

@colin-rogers-dbt can you review this? 🙇

[Fleid]

@JCZuurmond are we doing this one?
Looks like the changelog entry is missing.

[colin-rogers-dbt]

Have we tested this manually? I don't think our existing tests cover this case. At the very least we should open an issue to update our automated tests.

[colin-rogers-dbt]

@etheleon can you add a changelog entry?

[etheleon]

hey @colin-rogers-dbt working on it 👍

• added changelog
• yes tested locally with jaffle shop example. ran SHOW CREATE TABLE to get the table definition now it includes tblproperties

/*
    Welcome to your first dbt model!
    Did you know that you can also configure models directly within SQL files?
    This will override configurations stated in dbt_project.yml

    Try changing "table" to "view" below
*/

{{
    config(
        location_root='s3a://some_bucket/tables',
        tblproperties = {
          'format': 'iceberg/parquet',
          'format-version': '2',
          'write.delete.mode': 'merge-on-read',
          'write.delete.target-file-size-bytes': '536870912',
          'write.merge.mode': 'merge-on-read',
          'write.metadata.delete-after-commit.enabled': 'true',
          'write.metadata.previous-versions-max': '100',
          'write.target-file-size-bytes': '536870912',
          'write.update.mode': 'merge-on-read'}
    )
}}

with source_data as (

    select 1 as id
    union all
    select null as id

)

select *
from source_data

/*
    Uncomment the line below to remove records with null `id` values
*/

-- where id is not null

output from SHOW CREATE TABLE

CREATE TABLE Iceberg catalog.ds.my_first_dbt_model ( id INT) USING iceberg LOCATION 's3a://some_bucket/tables/my_first_dbt_model' TBLPROPERTIES ( 'current-snapshot-id' = '1344159441507971776', 'format' = 'iceberg/parquet', 'format-version' = '2', 'write.delete.mode' = 'merge-on-read', 'write.delete.target-file-size-bytes' = '536870912', 'write.merge.mode' = 'merge-on-read', 'write.metadata.delete-after-commit.enabled' = 'true', 'write.metadata.previous-versions-max' = '100', 'write.target-file-size-bytes' = '536870912', 'write.update.mode' = 'merge-on-read')