-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tabs in dbt_project.yml to 2 spaces instead of 4 #11
Conversation
@drewbanin - would love if you could test this before merging as I'm worried about breaking everyone's dbt_project.yml files! |
thanks @alexiswo ! I didn't think of this at first, but there's one thing to note here: The @jtcohen6 i feel like we discussed this recently - do you recall where we ended up on this question? |
Where we ended up: We should start vendoring the starter project through |
Got it. So, should I leave this PR here? Or put a ticket somewhere for the future when dbt-labs/dbt-core#3005 is done? |
I think we can move ahead with this PR as is. That way, when we get around to dbt-labs/dbt-core#3005, we'll be moving the right (updated) code into the dbt repo :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good by me!
Note that, because dbt init
on versions >0.17.0
clones from the dbt-yml-config-version-2
tag, we'd need to recreate the dbt-yml-config-version-2
tag for this to take effect in newer vresions, which is a bit tricky. The whole thing is trickier than it needs to be IMO; I'd much rather just move this code into the dbt
repo and have starter projects tied to particular versions (dbt-labs/dbt-core#3005).
Also, this is (effectively) the same as #8, so I think we can close that after merging this. (There's a question there about whether to include the +
in front of the materialized
config, but let's save that for another day.)
Whoops! Didn't realize @jtcohen6 approved this. Merging now |
Details
Changes the
dbt_project.yml
file tab length to align with the tab length of 2 spaces specified in the YAML style guide section of the internal dbt coding convention docs AND the dbt_project.yml page on docs. Unifying the tab length will make it easier for users to copy and paste from the docs into their first projects, an issue that we see a lot of users run into during dbt Learn sessions.Testing
Copy and pasted this into the
dbt_project.yml
in a new project in dbt Cloud. Randbt run
without any issues. See screenshots below.