Fix/timestamp withought timezone (#458)

* timestamp and changelog updates * changelog fix * Add context for why change to no timezone Co-authored-by: Joel Labes <[email protected]>
dbt-labs · Dec 14, 2021 · 80e72c5 · 80e72c5
1 parent eb1ec81
commit 80e72c5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -1,5 +1,5 @@
 This is a:
-- [ ] bug fix PR with no breaking changes — please ensure the base branch is `master`
+- [ ] bug fix PR with no breaking changes — please ensure the base branch is `main`
 - [ ] new functionality — please ensure the base branch is the latest `dev/` branch
 - [ ] a breaking change — please ensure the base branch is the latest `dev/` branch
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+# dbt-utils (next version)
+## Fixes
+- `type_timestamp` macro now explicitly casts postgres and redshift warehouse timestamp data types as `timestamp without time zone`, to be consistent with Snowflake behaviour (`timestamp_ntz`). 
 # dbt-utils v0.8.0
 ## 🚨 Breaking changes
 - dbt ONE POINT OH is here! This version of dbt-utils requires _any_ version (minor and patch) of v1, which means far less need for compatibility releases in the future. 

diff --git a/macros/cross_db_utils/datatypes.sql b/macros/cross_db_utils/datatypes.sql
@@ -32,6 +32,10 @@
     timestamp
 {% endmacro %}
 
+{% macro postgres__type_timestamp() %}
+    timestamp without time zone
+{% endmacro %}
+
 {% macro snowflake__type_timestamp() %}
     timestamp_ntz
 {% endmacro %}