Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the deprecated identifier macro #669

Closed
joellabes opened this issue Sep 15, 2022 · 0 comments · Fixed by #672
Closed

Delete the deprecated identifier macro #669

joellabes opened this issue Sep 15, 2022 · 0 comments · Fixed by #672
Labels
1.0 Changes to include in version 1.0 (especially breaking changes) enhancement New feature or request good first issue

Comments

@joellabes
Copy link
Contributor

Describe the feature

For a long time, identifer() has been labeled as deprecated:

{%- set error_message = '
Warning: the `identifier` macro is no longer supported and will be deprecated in a future release of dbt-utils. \
Use `adapter.quote` instead. The {}.{} model triggered this warning. \
'.format(model.package_name, model.name) -%}
{%- do exceptions.warn(error_message) -%}

Its time has come.

This one is pretty easy! Just a case of deleting the file. As far as I can see, it doesn't have any tests associated with it, and it's no longer used in any dbt_utils macros. If, when you do delete it, it causes some tests to fail, replace them with adapter.quote as needed.

Who will this benefit?

Appreciators of clean code everywhere

Are you interested in contributing this feature?

Nope - this one feels perfect for a community contribution!

@joellabes joellabes added enhancement New feature or request good first issue 1.0 Changes to include in version 1.0 (especially breaking changes) labels Sep 15, 2022
miles170 added a commit to miles170/dbt-utils that referenced this issue Sep 15, 2022
miles170 added a commit to miles170/dbt-utils that referenced this issue Sep 15, 2022
miles170 added a commit to miles170/dbt-utils that referenced this issue Sep 15, 2022
miles170 added a commit to miles170/dbt-utils that referenced this issue Sep 19, 2022
joellabes pushed a commit that referenced this issue Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Changes to include in version 1.0 (especially breaking changes) enhancement New feature or request good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant