dispatch-ify ALL THE MACROS!

[dataders]

This is a:

• bug fix PR with no breaking changes — please ensure the base branch is master
• new functionality — please ensure the base branch is the latest dev/ branch
• a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

see #311
cc: @alittlesliceoftom

Checklist

• I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
  • BigQuery
  • Postgres
  • Redshift
  • Snowflake
• I have updated the README.md (if applicable)
• I have added tests & descriptions to my models (and macros if applicable)
• I have added an entry to CHANGELOG.md

[dataders]

@jtcohen6 not sure what I've done here...

Encountered an error:
Compilation Error in test dbt_utils_equality_test_generate_series_ref_data_generate_series_ (models/sql/schema.yml)
  macro 'dbt_macro__test_equality' takes no keyword argument 'arg'
  
  > in macro test_equality (macros/schema_tests/equality.sql)
  > called by test dbt_utils_equality_test_generate_series_ref_data_generate_series_ (models/sql/schema.yml)

[jtcohen6]

Nice PR! I think this is the way to go.

You need to allow for passing kwargs through the macro dispatcher. It's a bit tricky.

[clrcrl]

Removing myself as reviewer, as Jeremy has it covered :)

[dataders]

onto the next thing... I don't have a postgres target handy (but can get one running without too much trouble probably). @jtcohen6 any shoves in the right direction here? I haven't the slightest how the dispatch addition would make a test fail...

Failure in test dbt_utils_expression_is_true_data_test_expression_is_true_col_b_0_5__col_a_0_5 (models/schema_tests/schema.yml)
  Got 2 results, expected 0.

  compiled SQL at target/compiled/dbt_utils_integration_tests/models/schema_tests/schema.yml/schema_test/dbt_utils_expression_is_true_data_test_expression_is_true_col_b_0_5__col_a_0_5.sql

[jtcohen6]

Thanks for all the hard work here @swanderz @chaerinlee1! Truly a public service on behalf of all adapter plugin users

[clrcrl]

If my memory serves me correctly, we don't want to pass through the defaults twice. e.g. instead of:

{% macro test_expression_is_true(model, condition='true') %}
This conversation was marked as resolved by swanderz
  {{ return(adapter.dispatch('test_expression_is_true', packages = dbt_utils._get_utils_namespaces())(model, condition, **kwargs)) }}
{% endmacro %}

{% macro default__test_expression_is_true(model, condition='true') %}
...

We only want:

...
{% macro default__test_expression_is_true(model, condition) %}
...

See #279

[jtcohen6]

@clrcrl It really could be an issue! I was trying to remember earlier today.

The problem in #279 is that we passed the default args into a macro call—not explicitly an issue with repeating them across two macro signatures.

[clrcrl]

oh right, yes I see the difference now!

[dataders]

let this comment stand in for what should have been marking my draft PR as ready for review!

[clrcrl]

@jtcohen6 — I'm going to let you do the honors here (unless you'd prefer me to!)

0.6.4 seems imminent!

[jtcohen6]

Let's ship it!!

@swanderz Could you add a changelog entry (I think "under the hood"), and add yourself + @chaerinlee1 as contributors?

[dataders]

comme ça?

[jtcohen6]

merci !