Snowflake: get_tables_by_pattern_sql handling external tables #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README.md * Update README.md Co-authored-by: Jeremy Cohen <[email protected]> * Update README.md Co-authored-by: Jeremy Cohen <[email protected]> * Update README.md * Update README.md Co-authored-by: Jeremy Cohen <[email protected]>
5 tasks
jtcohen6
reviewed
Apr 6, 2021
There was a problem hiding this comment.
Looking good @upjohnc! I gave a few minutes' thought to integration-testing this, and it's a bit tricky, so I'm going to say that your + my end-user testing is sufficient.
I left one comment. Could you also add a changelog entry, under a new section for dbt-utils v0.6.5?
Co-authored-by: Jeremy Cohen <[email protected]>
|
I'm going to switch this out to dev/0.7.0 since I want to get a release out in the next week or so! We'll have to 0.8.0 when dbt 0.20.0 comes out |
5 tasks
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
masterdev/branchdev/branchDescription & motivation
Adding handling of snowflake external tables in get_tables_by_pattern_sql
Checklist
Linked Issue
I don't seem to have access to link this pr to the issue
issue url