Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix sequential values timestamp #376

Merged
merged 5 commits into from
Jun 1, 2021
Merged

Hotfix sequential values timestamp #376

merged 5 commits into from
Jun 1, 2021

Conversation

dataders
Copy link
Contributor

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

Synapse doesn't have a timestamp type, instead dbt_utils.type_timestamp() should be used.

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@dataders dataders marked this pull request as ready for review May 30, 2021 20:14
@dataders dataders requested a review from clrcrl as a code owner May 30, 2021 20:14
dataders added a commit to dbt-msft/tsql-utils that referenced this pull request May 30, 2021
@dataders
disable until dbt-labs/dbt-utils#376 is approved
8e1d959
@dataders dataders mentioned this pull request May 30, 2021
Merged
clrcrl
clrcrl approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@clrcrl clrcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get the changelog updated and make a quick release :)

CHANGELOG.md Outdated Show resolved Hide resolved
@clrcrl clrcrl merged commit 00ebcb8 into dbt-labs:master Jun 1, 2021
@dataders
Copy link
Contributor Author

dataders commented Jun 1, 2021

thanks @clrcrl!

claire_bueller.jpg

@dataders dataders mentioned this pull request Nov 9, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clrcrl clrcrl clrcrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dataders @clrcrl