Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 506 updating star.sql file #532

Merged
merged 2 commits into from
Apr 5, 2022
Merged

fix issue 506 updating star.sql file #532

merged 2 commits into from
Apr 5, 2022

Conversation

KamranAMalik
Copy link
Contributor

@KamranAMalik KamranAMalik commented Mar 30, 2022 •
edited
Loading

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is main
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

This PR is fixing the issue mentioned here: #506

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt_utils.type_* macros instead of explicit datatypes (e.g. dbt_utils.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@KamranAMalik KamranAMalik marked this pull request as ready for review March 30, 2022 21:14
@joellabes joellabes linked an issue Apr 5, 2022 that may be closed by this pull request
dbt_utils.star macros bug #506
Closed
5 tasks
joellabes
joellabes requested changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - just suggested removing a duplicate line 🎉

macros/sql/star.sql Outdated Show resolved Hide resolved
@joellabes joellabes merged commit b33df57 into dbt-labs:main Apr 5, 2022
@joellabes
Copy link
Contributor

Thanks for opening this @KamranAMalik!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dbt_utils.star macros bug
2 participants
@KamranAMalik @joellabes