Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace legacy CircleCI PostgreSQL convenience image #585

Merged
merged 6 commits into from
May 12, 2022
Merged

Replace legacy CircleCI PostgreSQL convenience image #585

merged 6 commits into from
May 12, 2022

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented May 12, 2022 •
edited
Loading

Resolves #584

This is:

  • documentation
  • bug fix with no breaking changes
  • new functionality
  • breaking change
  • continuous integration testing

All pull requests from community contributors should target the main branch (default).

Description & motivation

Two things:

  • upgrade to a next-gen docker convenience image in CircleCI
  • change from patch version image to a minor version

The latter is so we will automatically utilize new patch versions of the convenience image as they are rolled out.

Checklist

  • I have verified that these changes work on the supported warehouses
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@dbeatty10 dbeatty10 marked this pull request as ready for review May 12, 2022 15:36
@dbeatty10 dbeatty10 requested a review from jasnonaz May 12, 2022 15:37
jasnonaz
jasnonaz approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@jasnonaz jasnonaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@dbeatty10 dbeatty10 merged commit c5ea35a into main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnonaz jasnonaz jasnonaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircleCI deprecated Docker convenience image
2 participants
@dbeatty10 @jasnonaz